audit: Fix Regexp for stripping .git from repo URLs
#7644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
May 25, 2020
- [For a formula named turbogit](Homebrew/homebrew-core#55208), we didn't see any of the notability checks fail CI. - The repo name was getting truncated to `turb`, which didn't exist, so the audit didn't return anything for this check. - The Regexp to strip `.git` from the end of was not escaping the `.`, so it would match anything ending in `git`, not a literal `.git`.
issyl0
force-pushed
the
audit-fix-regex-parsing-for-git
branch
from
d8cba67
to
0cced8e
Compare
``` ➜ brew audit --online --new-formula --verbose turbogit turbogit: * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars) * GitHub repository too new (<30 days old) Error: undefined local variable or method `created_pr_comment' for Homebrew:Module /usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:148:in `audit' /usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>' ``` - This was removed in 4f75a77. We can't post PR comments from GitHub Actions CI from forks.
issyl0
force-pushed
the
audit-fix-regex-parsing-for-git
branch
from
e990786
to
d14eed6
Compare
MikeMcQuaid
approved these changes
May 25, 2020
|
Thanks, I'll merge this when it's (finally) green. 🙄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you written new tests for your changes? Here's an example.brew stylewith your changes locally?brew testswith your changes locally?turb, which didn't exist, so the audit didn't return anything for this check..gitfrom the end of a repo URL was not escaping the., so it would match anything ending ingit, not a literal.git.